[PATCH] D74589: [ADT] Allow empty string in StringSet

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good - please commit the StringPool fix separately & I'd personally probably remove the wasm test, but I can see the merit in including it too, so up to you there.

> I also looked back though the history to identify the original reason for this limitation and it came, not from the data structure but from its domain-specific origin (a place where empty strings were not expected).

Could you include a few of the details from the history there to explain it in the commit message?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74589/new/

https://reviews.llvm.org/D74589