[PATCH] D76829: [lit] Introduce setup and teardown routines

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 15:27:09 PDT 2020


yln added a comment.

> I personally believe that a more useful feature for lit would be to allow batching sets of RUN commands or something like that. For example, imagine if we could compile all the tests locally and only then execute them on the remote host -- you wouldn't only save the cost of scping N times, you would also save on all the ssh's. That would be a major improvement. To me, trying to just save on copying the inputs is taking the easy way for less benefit, and it's not clear to me this will even work with the upcoming libc++ lit configuration, where each test will require its copy of the inputs.
> 
> By the way, I don't mean to say that this patch isn't useful -- I'm just saying that in the context of trying to solve the specific problem at hand (libc++'s std::filesystem on a remote host), I'm not convinced this is the right thing.

Without a strong use case from libc++ I would prefer to hold off on this and see if it is still needed after we made the other improvements.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76829/new/

https://reviews.llvm.org/D76829





More information about the llvm-commits mailing list