[PATCH] D76951: [llvm-rc] Allow -1 for menu item IDs

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 14:52:55 PDT 2020


amccarth accepted this revision.
amccarth added a comment.

Negative values, especially -1, for unneeded IDs is indeed a very things in Windows resource files, not just for menu items (and submenus) but also for decorative controls on dialogs.  So this looks fine to me, though we might eventually have to relax the constraints even more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76951/new/

https://reviews.llvm.org/D76951





More information about the llvm-commits mailing list