[PATCH] D76571: [mlir] Start simple EmitC dialect.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 13:43:19 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/test/Target/cpp-calls.mlir:17
+  // CHECK: foo::print([[V3]]);
+  emitc.call "foo::print"(%2): (i32) -> ()
+  return
----------------
I am a bit confused by the design of this dialect. I don't really get why we need a dialect for expressing this instead of... just emitting the C++ code directly for example.

What other ops would go into the "emitc" dialect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76571/new/

https://reviews.llvm.org/D76571





More information about the llvm-commits mailing list