[PATCH] D76248: Fix a bug in the inliner that causes subsequent double inlining

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 13:43:18 PDT 2020


hoyFB marked an inline comment as done.
hoyFB added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:721
+            // callsite will be reconsidered here.
+            for (auto &II : CallSites)
+              assert(II.first != CallSite(Ptr));
----------------
davidxl wrote:
> This has quadratic behavior and can cause excessive compile time increase for some cases with assertion on. Use a DenseSet to avoid that.
Good point! I was not aware of debug build throughput could be an issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76248/new/

https://reviews.llvm.org/D76248





More information about the llvm-commits mailing list