[PATCH] D76671: [FileCollector] Add a method to add a whole directory and it contents.

[Alex Lorenz via Phabricator via llvm-commits]

arphaman added inline comments.


================
Comment at: llvm/lib/Support/FileCollector.cpp:78
+  for (; Iter != End && !EC; Iter.increment(EC)) {
+    if (sys::fs::is_regular_file(Iter->path()))
+      addFile(Iter->path());
----------------
It looks like the is_regular_file check doesn't take the previously used `sys::fs::file_type::directory_file` and `sys::fs::file_type::symlink_file` file types into account. Is that intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76671/new/

https://reviews.llvm.org/D76671