[PATCH] D75646: Add an SDK attribute to DICompileUnit

Fri Mar 27 11:28:38 PDT 2020

dblaikie added inline comments.

================
Comment at: llvm/lib/Bitcode/Reader/MetadataLoader.cpp:1475-1476
         Record.size() <= 18 ? 0 : Record[18],
         false, // FIXME: https://reviews.llvm.org/rGc51b45e32ef7f35c11891f60871aa9c2c04cd991
                // Record.size() <= 19 ? 0 : Record[19],
+        Record.size() <= 20 ? nullptr : getMDString(Record[20]),
----------------
aprantl wrote:
> davide wrote:
> > Unrelated, but ugh about this FIXME.
> Let's ping @dblaikie about that :-)
Yeah, poked at the internal failure that I'm not currently able to reproduce & asked some folks - so after that, if no one's got better ideas I'll try resubmitting c51b45e32ef7f35c11891f60871aa9c2c04cd991

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75646/new/

https://reviews.llvm.org/D75646