[PATCH] D76852: [lld test] Tighten ELF/pre_init_fini_array.s test

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: lld/test/ELF/pre_init_fini_array.s:6
 // RUN: ld.lld %t %t2.so -o %t2
-// RUN: llvm-readobj -r --symbols --sections --dynamic-table %t2 | FileCheck %s
-// RUN: llvm-objdump -d %t2 | FileCheck --check-prefix=DISASM %s
+// RUN: llvm-readelf -S -s -r --dynamic %t2 | FileCheck %s
+// RUN: llvm-objdump -d --syms %t2 | FileCheck --check-prefix=DISASM %s
----------------
-S --dynamic -r -s (or -S -d -r -s) is better because the option order matches the output order.


================
Comment at: lld/test/ELF/pre_init_fini_array.s:30
 
-// CHECK:      Name: .init_array
-// CHECK-NEXT: Type: SHT_INIT_ARRAY
-// CHECK-NEXT: Flags [
-// CHECK-NEXT:   SHF_ALLOC
-// CHECK-NEXT:   SHF_WRITE
-// CHECK-NEXT: ]
-// CHECK-NEXT: Address: [[INIT_ADDR:.*]]
-// CHECK-NEXT: Offset:
-// CHECK-NEXT: Size: [[INIT_SIZE:.*]]
+// CHECK-LABEL: Section Headers
+// CHECK:      Name           Type          Address                 Off       Size                    ES Flg
----------------
`Section Headers:`


================
Comment at: lld/test/ELF/pre_init_fini_array.s:47
+// CHECK-LABEL: Symbol table '.symtab'
+// CHECK: Value                                   Size Type    Bind   Vis       Ndx   Name
+// CHECK:       [[# FINI_ADDR + FINI_SIZE]]       0    NOTYPE  LOCAL  HIDDEN    [[#]] __fini_array_end
----------------
`Value` is misaligned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76852/new/

https://reviews.llvm.org/D76852