[PATCH] D76881: [AMDGPU] Skip CFIInstructions in SIInsertWaitcnts

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D76881#1946435 <https://reviews.llvm.org/D76881#1946435>, @scott.linder wrote:

> Right, but the placement of the meta instructions here can't affect change codegen, can it? Also, if we do need to skip the DEBUG_VALUEs it may also be that we would need to either update or drop them to avoid producing incorrect debug info. I'm not actually certain this is an issue though, but the situation I have in mind is if we pass an argument by-ref or on the stack, and in the callee we claim the value is in memory when the appropriate counts haven't been waited on yet.


Doesn't the placement of CFI matter relative to the real instructions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76881/new/

https://reviews.llvm.org/D76881