[PATCH] D72092: [test][ELF] Use CHECK-NEXT to properly check error messages

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D72092#1945523 <https://reviews.llvm.org/D72092#1945523>, @MaskRay wrote:

> In D72092#1945410 <https://reviews.llvm.org/D72092#1945410>, @dblaikie wrote:
>
> > @MaskRay I know it's a bit quirky, but Phabricator doesn't send email to the list on status changes (like approvals) that contain no user-authored text, which makes it look like patches are being committed without approval (if you're just reading the mailing list). If you could write a little something ("Thanks", "Looks good", etc) whenever approving a patch, it'd help make sure the mailing list accurately reflects the state of patches - thanks!
>
>
> @dblaikie I actually read a similar comment from you to another person. Thanks for the reminder! To prevent me from forgetting, I created a Tampermonkey script:
>
>   const select = document.querySelector('.aphront-form-input > select')
>   if (select)
>     select.onchange = function() {
>       const accept = select.querySelector('option[value=accept]')
>       if (accept && accept.disabled) {
>         const comment = document.querySelector('.remarkup-assist-textarea')
>         if (comment && comment.value.length == 0) {
>           const words = ['LGTM.', 'Thanks!', 'Looks great!']
>           comment.value = words[~~(Math.random()*words.length)]+' '
>           comment.focus()
>         }
>       }
>     }
>   


oh, nifty! Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72092/new/

https://reviews.llvm.org/D72092