[PATCH] D76886: [InlineFunction] Disable emission of alignment assumptions by default

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 10:55:26 PDT 2020


hfinkel added a comment.

I don't object to doing this, but...

> After looking at IR diffs a bit more, one difference I noticed is that jump threading is not being performed in some places. In this case the reason is not multi-use, but cost heuristics based on instruction counts. The alignment assumption adds 4 extra instructions, and if the block duplication threshold is at 6 instructions, that can easily make a difference.

This an independent problem that we might fix first. Jump threading should be collecting and ignoring ephemeral values for it's heuristic. If it's not doing that, please fix that first and then reevaluate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76886/new/

https://reviews.llvm.org/D76886





More information about the llvm-commits mailing list