[PATCH] D76885: [lld][ELF][WebAssembly] Replace --(no-)threads with --threads=N
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 27 10:17:18 PDT 2020
MaskRay marked an inline comment as done.
MaskRay added a subscriber: aganea.
MaskRay added inline comments.
================
Comment at: lld/wasm/Options.td:98
-def threads: F<"threads">, HelpText<"Run the linker multi-threaded">;
+defm threads : Eq<"threads", "Number of threads. 0 (default) means all of "
+ "concurrent threads supported">;
----------------
grimar wrote:
> I'd probably expect to see a behavior when with `--threads==0` we either report error or just disable multithreading (i.e. `threads==0` == `threads==1`)? Perhaps the default could be `-1`.
@aganea There is a debate about 0 vs -1. What's your opinion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76885/new/
https://reviews.llvm.org/D76885
More information about the llvm-commits
mailing list