[PATCH] D76162: [AIX] discard the label in the csect of function description and use qualname for linkage
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 27 09:41:24 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1568
if (const Function *F = dyn_cast<Function>(CV)) {
- MCSymbolXCOFF *FSym = cast<MCSymbolXCOFF>(getSymbol(F));
- if (!FSym->hasContainingCsect()) {
MCSectionXCOFF *Csect = cast<MCSectionXCOFF>(
F->isDeclaration()
----------------
jasonliu wrote:
> jasonliu wrote:
> > clang format this block, I don't think the spaces are aligned correctly.
> This comment is not addressed when you land the commit.
Could we land a commit to address this before we all forget? Please comment if you landed this change. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76162/new/
https://reviews.llvm.org/D76162
More information about the llvm-commits
mailing list