[PATCH] D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp.

[Andy Davis via Phabricator via llvm-commits]

andydavis1 marked 9 inline comments as done.
andydavis1 added a comment.

Thanks. I've addressed comments and will update with a new patch soon...



================
Comment at: mlir/lib/Dialect/Vector/VectorTransforms.cpp:825
 //   -> User(Producer)
 struct TupleGetFolderOp : public OpRewritePattern<vector::TupleGetOp> {
   using OpRewritePattern<vector::TupleGetOp>::OpRewritePattern;
----------------
aartbik wrote:
> just curious, this is part of VectorTransforms explicitly now.
> 
> Does it make sense to do this as part of the  TupleGetOp::fold() at some point?
Perhaps. What are the tradeoffs of moving it to a fold method?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76889/new/

https://reviews.llvm.org/D76889