[PATCH] D76875: [NFC] [PPC] [AIX] Test improvements for byval arguments that fit in a single register

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm marked 2 inline comments as done.
cebowleratibm added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval.ll:118
+  %0 = load float, float* @f, align 4
+  %call = call zeroext i8 @test_byval_2Byte(i32 signext 42, float %0, %struct.S2* byval(%struct.S2) align 1 @gS2, float %0, i32 signext 43)
   ret void
----------------
ZarkoCA wrote:
> I think making one of the floats a double would be more useful to show how the 32BIT AIX ABI works.  
We have other tests that mix floats and doubles.  The point here was to validate that the byval arg shuffles the arguments around it properly.  I prefer to leave this as-is.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval.ll:181
 
-
-define zeroext i8 @test_byval_2Byte(%struct.S2* byval(%struct.S2) align 1 %s) {
+define zeroext i8 @test_byval_2Byte(i32, float, %struct.S2* byval(%struct.S2) align 1 %s, float, i32) {
 entry:
----------------
ZarkoCA wrote:
> Same as above with respect to using a double instead of float, but I think you only need do it one time. 
I think this is minimal value add.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76875/new/

https://reviews.llvm.org/D76875