[PATCH] D76124: [TTI] Remove getOperationCost
Ulrich Weigand via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 27 07:37:10 PDT 2020
uweigand added a comment.
Looking simply at the SystemZ test case change, for the icmp/[zs]ext case (fun1/fun2), we actually need three instructions (compare, load zero, conditional move), so the change seems reasonable.
For the fun5 case, we actually can do the extension in a single instruction if the input is already in a register, so that change looks wrong. On the other hand, if I understand correctly, with the new approach after this patch we actually have greater control in the backend TTI and could fix that case there?
Then overall I guess I'd be OK with this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76124/new/
https://reviews.llvm.org/D76124
More information about the llvm-commits
mailing list