[PATCH] D74205: [llvm-dwarfdump] Add the --show-sections-sizes option

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 07:03:23 PDT 2020


djtodoro added a comment.

I think that @aprantl wanted a test for Mach-O and archives, back then. I've added a test for mach-o and archive, in one shot (by using pre-existing fat mach-o archive from dsymutil). Then, I've added different tests for individual targets (elf, mach-o and coff) in order to confirm we use the right `isDebugSection()` and by not including a debug section from different name styling (we wasn't able to check that with existing mach-o test, since we had the pre-existing fat mach-o archive from dsymutil test). Furthermore, we decided not to  use pre-existing Inputs/ from different tools, so I've added the `llvm/test/tools/llvm-dwarfdump/X86/section_sizes_archive.test`, by testing archives. I don't think we would test something new by adding another fat archive test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74205/new/

https://reviews.llvm.org/D74205





More information about the llvm-commits mailing list