[PATCH] D60940: [X86] Don't form masked instructions if the operation has an additional user.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 05:56:35 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a few typo corrections



================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:727
 
+// Indicates it is profitable form an AVX512 masked operation. Returning false
+// will favor a masked register-register blend and the operation will be
----------------
typo?


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:734
+
+  // If the operation has additional users, the operaiton will be duplicated.
+  // Check the use count to preven that.
----------------
operation


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:735
+  // If the operation has additional users, the operaiton will be duplicated.
+  // Check the use count to preven that.
+  // FIXME: Are there cheap opcodes we might want to duplicate?
----------------
preven?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60940/new/

https://reviews.llvm.org/D60940





More information about the llvm-commits mailing list