[PATCH] D74205: [llvm-dwarfdump] Add the --show-sections-sizes option

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Hi @aprantl,

Do you think a regular llvm-ar archive test is sufficient for this testing, or do you think a mach-o fat archive is important to test independently? I don't see a massive need for the latter personally.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/section_sizes_archive.test:13
+
+#      CHECK:file: {{.*}}
+# CHECK-NEXT:----------------------------------------------------
----------------
Please include the actual file path here and below. You may need to use FileCheck's -D to achieve this, e.g. `FileCheck %s -DFILE1=%t.1.o -DFILE2=%t.2.o --match-full-lines --strict-whitespace`.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/section_sizes_archive.test:23-24
+# CHECK-NEXT:----------------------------------------------------
+
+#      CHECK:file: {{.*}}
+# CHECK-NEXT:----------------------------------------------------
----------------
You should probably make this a continuous series of CHECK-NEXT/CHECK-EMPTY, to show what the formatting between blocks looks like.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/section_sizes_archive.test:28-29
+# CHECK-NEXT:-----------  --------
+# CHECK-NEXT:.debug_loc          1 (0.20%)
+# CHECK-NEXT:.debug_type        13 (2.54%)
+# CHECK-EMPTY:
----------------
Change one of these two sections to use the same name as one from the first object, to show that the sizes are independent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74205/new/

https://reviews.llvm.org/D74205