[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 2 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:75
+/// section.
+enum MacroSecType { MACINFO = 1, MACINFODWO, MACRO, MACRODWO };
+
----------------
ikudrin wrote:
> I guess that it is better to make this enum private inside `DWARFContext`.
> 
> You may also want to remove `MACRODWO` because it is used only for an empty ("TODO") case in `parseMacroOrMacinfo()`. Just remove that empty case and move the "TODO" comment to this enum.
Thanks, I'll take care of that in next revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086