[PATCH] D76817: `shape` dialect: add some ops

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added a comment.

Nice, I think one more round and it is good



================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:189
+    in the tensor equals the rank of the shape, and the elements equal the
+    extents of the shape.
+  }];
----------------
What happens for unranked and or dynamic tensors?


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:193
+  let arguments = (ins Shape_ShapeType:$input);
+  let results = (outs I32Tensor:$result);
+}
----------------
With your other rev, can these now be IndexTensor? (can also be done in follow up)


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:335
+    - split_at([4,5,6], index=-3) -> [], [4,5,6]
+    - split_at([4,5,6], index=-4) -> error
+
----------------
Add behavior for unranked here and below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76817/new/

https://reviews.llvm.org/D76817