[PATCH] D76637: [mlir][Linalg] Allow tiling of batch dimension for convolution ops with padding.

[Han-Chung Wang via Phabricator via llvm-commits]

hanchung accepted this revision.
hanchung added a comment.

LGTM, would be good to wait until Nicolas taking a look.



================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp:437-438
+  if (auto convOp = dyn_cast<linalg::ConvOp>(op.getOperation())) {
+    // For conv op only support tiling along batch dimension (which is the first
+    // loop)
+    if (convOp.padding() && !llvm::all_of(tileSizes.drop_front(),
----------------
same here, missing a period at the end.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76637/new/

https://reviews.llvm.org/D76637