[PATCH] D76893: Move setBugReportMsg() out from under a conditional

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 16:20:20 PDT 2020


probinson created this revision.
probinson added a reviewer: leonardchan.
Herald added a subscriber: hiraditya.
probinson added a comment.

For some reason my git environment is hosed and I can't commit this directly at the moment.
@leonardchan  go ahead and commit this.


Fixes a build break with LLVM_ENABLE_BACKTRACES=OFF.


https://reviews.llvm.org/D76893

Files:
  llvm/lib/Support/PrettyStackTrace.cpp


Index: llvm/lib/Support/PrettyStackTrace.cpp
===================================================================
--- llvm/lib/Support/PrettyStackTrace.cpp
+++ llvm/lib/Support/PrettyStackTrace.cpp
@@ -146,8 +146,6 @@
     "PLEASE submit a bug report to " BUG_REPORT_URL
     " and include the crash backtrace.\n";
 
-void llvm::setBugReportMsg(const char *Msg) { BugReportMsg = Msg; }
-
 /// This callback is run if a fatal signal is delivered to the process, it
 /// prints the pretty stack trace.
 static void CrashHandler(void *) {
@@ -204,6 +202,12 @@
 
 #endif // ENABLE_BACKTRACES
 
+void llvm::setBugReportMsg(const char *Msg) {
+#if ENABLE_BACKTRACES
+  BugReportMsg = Msg;
+#endif
+}
+
 PrettyStackTraceEntry::PrettyStackTraceEntry() {
 #if ENABLE_BACKTRACES
   // Handle SIGINFO first, because we haven't finished constructing yet.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76893.253003.patch
Type: text/x-patch
Size: 842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200326/4e8f677c/attachment.bin>


More information about the llvm-commits mailing list