[PATCH] D76602: [MLIR] Introduce std.alloca op
Diego Caballero via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 26 14:42:14 PDT 2020
dcaballe added a comment.
> Note that the 'a' suffix in 'alloca' is for 'automatic' freeing
Thanks for clarifying! I thought it was just a short for 'allocate' :)
> Can we make it explicit then: stack_alloc?
stack_alloc sounds better to me, thanks.
> Since 'alloc' currently doesn't specify where it's from the stack/heap and specifies it's explicitly freed via dealloc, we can leave it like that.
It sounds good. I think we are mapping 'alloc' to static allocation by using a flag in the llvm lowering. Maybe can create a simple pass to do a more proper alloc->static_alloc conversion in the future and leave 'alloc' only for heap allocation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76602/new/
https://reviews.llvm.org/D76602
More information about the llvm-commits
mailing list