[PATCH] D76007: [TableGen][GlobalISel] Account for HwMode in RegisterBank register sizes

Benjamin Kramer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 14:42:12 PDT 2020


bkramer added a comment.

In D76007#1944582 <https://reviews.llvm.org/D76007#1944582>, @lewis-revill wrote:

> I'm lacking an understanding of how concurrency is expected to work within LLVM, but since there is only one RegisterBankInfo constructed per subtarget I don't see how there is a problem with updating the global RegBanks array? Likewise the HwMode is constant for the subtarget, so the write will be of the same value.


There can be many subtargets around, and those can be created concurrently. Having state in a global variable is not going to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76007/new/

https://reviews.llvm.org/D76007





More information about the llvm-commits mailing list