[PATCH] D49116: Setup clang-format as an Arcanist linter

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a reviewer: scott.linder.
scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

I don't know if I'm the right person to approve this, but it seems like there is pretty reasonable consensus that this is a good thing, and with Harbormaster beginning to mark formatting errors with big scary red X's I think landing this sooner rather than later will cut down on some of the review noise.

I left a small nit, but I think the script looks good as-is.



================
Comment at: utils/arcanist/clang-format.sh:13
+
+if ! command -v clang-format-diff >/dev/null; then
+  # advice severity level is completely non-disruptive.
----------------
This could be changed to use `hash`, which is a bit shorter and means you skip the PATH lookup later.

i.e. `if ! hash clang-format-diff 2>/dev/null`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49116/new/

https://reviews.llvm.org/D49116