[PATCH] D76737: [mlir][vulkan-runner] Add support for 2D memref.

[Denis Khalikov via Phabricator via llvm-commits]

denis13 marked an inline comment as done.
denis13 added inline comments.


================
Comment at: mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp:102
+    // Create a type `!llvm<"{ float*, float*, i64, [2 x i64], [2 x i64]}">`.
+    llvmMemRef2DFloat = LLVM::LLVMType::getStructTy(
+        llvmDialect,
----------------
antiagainst wrote:
> This is similar enough with the above; but we only have two instance here so I'm fine with it atm. Might want to dedup by having a function later if there are more cases.
oops, I see, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76737/new/

https://reviews.llvm.org/D76737