[PATCH] D74781: Wasm-ld emits invalid .debug_ranges entries for non-live symbols

Thu Mar 26 13:39:03 PDT 2020

dblaikie added a comment.

In D74781#1944828 <https://reviews.llvm.org/D74781#1944828>, @sbc100 wrote:

> Regardless of any longer term plans for a new type of DWARF linking it seems that this change is strictly an improvement since (a) it matches the behavior of the existing ELF linker and (b) existing tools already handle this 0 ... N range.
>
> Any objections to landing this now?

My feedback isn't intended to be an objection (though I think it might be informative to understand if this bug doesn't appear in debug_loc without this patch... that surprises me, but low priority I suppose as it looks like the patch's fix would apply to debug_loc as well as it would to debug_ranges). I'll leave it to other wasm-y folks to approve, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74781/new/

https://reviews.llvm.org/D74781