[PATCH] D76879: [AMDGPU] Begin emitting CFI for AMDGCN

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relaxation.ll:257
 ; GCN-NEXT: .Lfunc_end{{[0-9]+}}:
-define amdgpu_kernel void @uniform_unconditional_min_long_forward_branch(i32 addrspace(1)* %arg, i32 %arg1) {
+define amdgpu_kernel void @uniform_unconditional_min_long_forward_branch(i32 addrspace(1)* %arg, i32 %arg1) #0 {
 bb0:
----------------
Why does it matter in any of these cases?


================
Comment at: llvm/test/DebugInfo/AMDGPU/cfi.ll:22
+
+attributes #0 = { nounwind "no-frame-pointer-elim"="true" }
+
----------------
This is the deprecated attribute. This should use frame-pointer=


================
Comment at: llvm/test/MC/ELF/AMDGPU/lit.local.cfg:2
+# We have to reset config.unsupported here because the parent directory is
+# predicated on 'X86'.
+config.unsupported = not 'AMDGPU' in config.root.targets
----------------
Copy paste X86


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76879/new/

https://reviews.llvm.org/D76879