[PATCH] D76881: [AMDGPU] Skip CFIInstructions in SIInsertWaitcnts
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 26 13:36:10 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1644
+ MachineBasicBlock::iterator I = EntryBB.begin();
+ for (MachineBasicBlock::iterator E = EntryBB.end();
+ I != E && (I->isPHI() || I->isCFIInstruction()); ++I)
----------------
Why just CFI? Why not isMetaInstruction?
================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-skip-cfi.mir:3-9
+--- |
+
+ define void @skip_cfi() {
+ ret void
+ }
+
+...
----------------
Shouldn't need IR section
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76881/new/
https://reviews.llvm.org/D76881
More information about the llvm-commits
mailing list