[PATCH] D76844: [InstCombine] try to reduce shuffle with bitcasted operand

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 12:29:35 PDT 2020


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

This seems reasonable to me, unless @RKSimon has concerns.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:1937-1939
+    SmallVector<Constant *, 16> ScaledMaskC;
+    for (unsigned i = 0; i != VWidth; ++i)
+      ScaledMaskC.push_back(Builder.getInt32(ScaledMask[i]));
----------------
Same comment about reserve+range-based-for, although i hope that will get obsoleted by D72467?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76844/new/

https://reviews.llvm.org/D76844





More information about the llvm-commits mailing list