[PATCH] D76863: Fix SelectionDAG Graph Printing on Windows

[Justice Adams via Phabricator via llvm-commits]

justice_adams updated this revision to Diff 252931.
justice_adams added a comment.

- removed static declaration from header file
- cleaned up code according to clang-tidy specifications


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76863/new/

https://reviews.llvm.org/D76863

Files:
  llvm/lib/Support/GraphWriter.cpp


Index: llvm/lib/Support/GraphWriter.cpp
===================================================================
--- llvm/lib/Support/GraphWriter.cpp
+++ llvm/lib/Support/GraphWriter.cpp
@@ -76,10 +76,31 @@
   return Colors[ColorNumber % NumColors];
 }
 
+static std::string replaceIllegalFilenameChars(std::string Filename,
+                                               const char ReplacementChar) {
+#ifdef _WIN32
+  std::string IllegalChars = "\\/:?\"<>|";
+#else
+  std::string IllegalChars = "/";
+#endif
+
+  for (std::string::iterator It = IllegalChars.begin(); It < IllegalChars.end();
+       ++It) {
+    std::replace(Filename.begin(), Filename.end(), *It, ReplacementChar);
+  }
+
+  return Filename;
+}
+
 std::string llvm::createGraphFilename(const Twine &Name, int &FD) {
   FD = -1;
   SmallString<128> Filename;
-  std::error_code EC = sys::fs::createTemporaryFile(Name, "dot", FD, Filename);
+
+  // Replace illegal characters in graph Filename with '_' if needed
+  std::string CleansedName = replaceIllegalFilenameChars(Name.str(), '_');
+
+  std::error_code EC =
+      sys::fs::createTemporaryFile(CleansedName, "dot", FD, Filename);
   if (EC) {
     errs() << "Error: " << EC.message() << "\n";
     return "";


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76863.252931.patch
Type: text/x-patch
Size: 1231 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200326/ae0d0e86/attachment.bin>