[PATCH] D76178: [lit] Recursively apply substitutions

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: llvm/utils/lit/lit/LitConfig.py:30
+                 echo_all_commands = False,
+                 recursiveExpansionLimit = None):
         # The name of the test runner.
----------------
ldionne wrote:
> delcypher wrote:
> > Maybe make the default `0` so it's clearer what the type is supposed to be?
> `None` and `0` are different -- `None` means no recursive substitution is attempted, and `0` means that recursive substitution is attempted up to 0 steps. But in the `0` case, it's still an error if there are unexpanded substitutions left after 0 recursive steps.
Ah okay. I hadn't noticed that difference. I've a left a comment elsewhere in the review that we should document this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76178/new/

https://reviews.llvm.org/D76178