[PATCH] D76658: [mlir][Pass] Move the registration of conversion passes to tablegen

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 11:22:59 PDT 2020


rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/Conversion/Passes.td:1
+//===-- Passes.td - Conversion pass definition file --------*- tablegen -*-===//
+//
----------------
jpienaar wrote:
> What happens if one only wants to include some subset of the passes? Perhaps in a doc somewhere.
That applies to all of the other documents that get generated as well. For example, if we want to split up the operations of a dialect and slice them in different ways(the current documentation for the standard dialect does this). I've been playing around with adding filtering based on some set of tags, or other identifiers. For operations there is already a desire for that, and it seems that could be equally applicable here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76658/new/

https://reviews.llvm.org/D76658





More information about the llvm-commits mailing list