[PATCH] D74589: [ADT] Allow empty string in StringSet

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 11:22:54 PDT 2020


dblaikie added a comment.

Probably best to test this functionality with a unit test for StringSet - but also please check if there's a reason StringSet might not support empty strings in its implementation in some way? (tombstone/other marker objects might be using "length 0" as a marker of some kind?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74589/new/

https://reviews.llvm.org/D74589





More information about the llvm-commits mailing list