[PATCH] D75684: [mlir][LLVM] Remove pessimizing std::move.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 26 10:18:11 PDT 2020
dblaikie added a comment.
In D75684#1942522 <https://reviews.llvm.org/D75684#1942522>, @mehdi_amini wrote:
> In D75684#1942146 <https://reviews.llvm.org/D75684#1942146>, @dblaikie wrote:
>
> > Just a quick note - PHabricator has a bug where it doesn't send email when status changes are made without text. @ftynse please include some text when approving patches to ensure that approval is reflected on the mailing list as well.
>
>
>
>
> I received an email on the approval, can you clarify?
Ah, guess it might send it specifically to the author only, then?
But it doesn't seem to make it to the mailing list: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200302/thread.html#751858
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75684/new/
https://reviews.llvm.org/D75684
More information about the llvm-commits
mailing list