[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 2 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:492
                  DObj->getMacinfoSection())) {
-    getDebugMacinfo()->dump(OS);
+    parseMacroOrMacinfo(Macinfo, OS, DumpOpts, /*IsLittleEndian=*/true,
+                        dwarf::Macinfo);
----------------
ikudrin wrote:
> Before the patch, `isLittleEndian()` was used, but now you always pass the constant `true`. Could you please elaborate, why the behavior has been changed?
Sorry, some how in effort to keeping the code concise this crept in. I've removed this since `parseMacroMacinfo` is a member function of `DWARFContext`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086