[PATCH] D76642: Make static linking for LLVM plugins more reliable.
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 26 08:38:55 PDT 2020
beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.
Yea... this is not how plugin linking should work.
Plugin host tools should link against the libraries. We do pass linker flags where necessary to reduce symbol dead stripping, but there is no expectation that all static archive symbols are in the tools. Which is why plugins themselves should be linked against first the plugin loader tool, then the LLVM static libraries that they themselves rely on.
See the `LLVMHello` Transform library plugin as an example.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76642/new/
https://reviews.llvm.org/D76642
More information about the llvm-commits
mailing list