[PATCH] D74205: [llvm-dwarfdump] Add the --show-sections-sizes option

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 2 inline comments as done.
djtodoro added a comment.

> What happened to "macho_archive_section_sizes.test"? I thought that was asked for for testing fat archives? On that note, it might be worth a test for llvm-ar produced archives too.

I'll add one. Thanks.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/section_sizes_coff.test:26
+    Characteristics: []
+    SectionData:     70726F647563657220737472696E6700746573742E63002F706174682F746F2F73726300
+  - Name:            .debug_abbrev
----------------
jhenderson wrote:
> jhenderson wrote:
> > If I'm not mistaken, these don't need to be valid data. Does COFF yaml2obj provide the "Size:" tag as an option for setting the section size? If not, I'd just use zeroes to write the data. Same goes below.
> Perhaps worth having one of these with a non-zero size?
Makes sense to me.


================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/section_sizes_coff.test:34
+    SectionData:     170000000400000000000401000000000C00000000000000000000
+## This is the debug section following the Mach-O naming style, so this is not included in the report.
+  - Name:            __debug_foo
----------------
jhenderson wrote:
> "This is the debug section following the Mach-O naming style, so this is not included in the report." -> "This is a debug section following the Mach-O naming style, and is used to show that it such sections are not included in the report."
Oh, my bad, I should have checked it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74205/new/

https://reviews.llvm.org/D74205