[PATCH] D75631: [llvm-objdump] Fix reliability of call target disassembling

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: lld/test/ELF/pre_init_fini_array.s:73-137
 // CHECK:        Name: __fini_array_end
 // CHECK-NEXT:   Value:
 // CHECK-NEXT:   Size: 0
 // CHECK-NEXT:   Binding: Local
 // CHECK-NEXT:   Type: None
 // CHECK-NEXT:   Other [
 // CHECK-NEXT:     STV_HIDDEN
----------------
This is somewhat redundant with the DISASM checks below, except for the cross-check of the address with the section that would be lost. Should this be removed noneless? Alternatively I could remove the whole readobj section and translate into llvm-objdump equivalent instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75631/new/

https://reviews.llvm.org/D75631