[PATCH] D76792: [InlineFunction] Update metadata on loads that are return values
Anna Thomas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 26 06:28:32 PDT 2020
anna marked 2 inline comments as done.
anna added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1168
return nullptr;
return VMI->second;
};
----------------
jdoerfert wrote:
> Isn't this just `VMap.lookup(V)`?
you're right. We don't need a lambda for this.
================
Comment at: llvm/test/Transforms/Inline/ret_load_metadata.ll:69
+}
+
+; CHECK: ![[NONNULL]] = !{i64 1}
----------------
jdoerfert wrote:
> Is there a test where the attribute is part of the callee and not the calls site?
Will add one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76792/new/
https://reviews.llvm.org/D76792
More information about the llvm-commits
mailing list