[PATCH] D76837: [NFC] Fix Z3 version detection regexp in llvm/cmake/modules/FindZ3.cmake

Balázs Benics via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 04:50:52 PDT 2020


steakhal created this revision.
steakhal added reviewers: NoQ, george.karpenkov, alexandre.isoard, serge-sans-paille.
Herald added subscribers: llvm-commits, martong, Charusso, mikhail.ramalho, mgorny.
Herald added a project: LLVM.

We use the `major.minor.build` version format in this file, except when we try to parse the result of the test binary.
In that regular expression, we expect the `major.minor.build.rev` format, which is never fulfilled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76837

Files:
  llvm/cmake/modules/FindZ3.cmake


Index: llvm/cmake/modules/FindZ3.cmake
===================================================================
--- llvm/cmake/modules/FindZ3.cmake
+++ llvm/cmake/modules/FindZ3.cmake
@@ -27,7 +27,7 @@
   )
 
   if(Z3_COMPILED)
-    string(REGEX REPLACE "([0-9]*\\.[0-9]*\\.[0-9]*\\.[0-9]*)" "\\1"
+    string(REGEX REPLACE "([0-9]*\\.[0-9]*\\.[0-9]*)" "\\1"
            z3_version "${SRC_OUTPUT}")
     set(Z3_VERSION_STRING ${z3_version} PARENT_SCOPE)
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76837.252799.patch
Type: text/x-patch
Size: 460 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200326/d33d63ea/attachment.bin>


More information about the llvm-commits mailing list