[PATCH] D76834: [yaml2obj] - Add NBucket and NChain fields for the SHT_HASH section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks fine to me. I'd like to see an example of it being used in a real test case, so I'm holding off on the LGTM until that point.



================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:282
 
+  // The following members are used to override section fields which is
+  // useful for creating invalid objects.
----------------
fields which -> fields. This


================
Comment at: llvm/test/tools/yaml2obj/ELF/hash-section.yaml:280
+
+## Check we can override "nbucket" and "nchain" values of a SHT_HASH section using "NBucket" and "NChain" tags.
+## Check that the section size is unaffected when we do this.
----------------
This line should probabbly be wrapped.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76834/new/

https://reviews.llvm.org/D76834