[PATCH] D76585: [PowerPC] Require NSZ flag for c-a*b to FNMSUB

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 03:12:54 PDT 2020


qiucf marked 2 inline comments as done.
qiucf added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/fma-negate.ll:289
+; NO-VSX-NEXT:    fmadd 1, 1, 3, 5
+; NO-VSX-NEXT:    fmadd 2, 0, 4, 6
 ; NO-VSX-NEXT:    blr
----------------
spatel wrote:
> qiucf wrote:
> > This should be a regression. And the reason is `SplitVectorRes` did not pass `SDNode` flags to legalized ones. If that's truly a bug, I will cook a patch for it.
> This should **not** be a regression, right? If we dropped the flags during legalization, that is a bug.
I posted the fix at D76832 :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76585/new/

https://reviews.llvm.org/D76585





More information about the llvm-commits mailing list