[PATCH] D75131: [llvm-objdump][XCOFF][AIX] Implement -r option

Thu Mar 26 02:40:31 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, once my last comment has been addressed and question answered (assuming that the question doesn't highlight an issue in the patch itself). Thanks for putting up with my lengthy review!

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-all.test:45-46
+CHECK:        00000090 <d>:
+ONLY-D-NEXT:      90: 00 00 00 00                  	<unknown>
+WITH-R-NEXT:      ...
+CHECK:        00000094 <func>:
----------------
I find this behaviour difference confusing. What is causing it?

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/print-reloc.test:30
+ CHECK-NEXT:00000014 R_POS                    .func
+ CHECK-NEXT:00000018 R_POS                    TOC
----------------
Still need a `CHECK-EMPTY:` at the end here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131