[PATCH] D76642: Make static linking for LLVM plugins more reliable.

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 02:07:52 PDT 2020


serge-sans-paille added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:928
       set_property(TARGET ${llvm_plugin_target} APPEND PROPERTY LINK_LIBRARIES ${llvm_extension})
+      set_property(TARGET ${llvm_plugin_target} APPEND PROPERTY LINK_LIBRARIES "obj.${llvm_extension}")
       set_property(TARGET ${llvm_plugin_target} APPEND PROPERTY INTERFACE_LINK_LIBRARIES ${llvm_extension})
----------------
In that case `set_property(TARGET ${llvm_plugin_target} APPEND PROPERTY LINK_LIBRARIES ${llvm_extension})` is no longer needed, is it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76642/new/

https://reviews.llvm.org/D76642





More information about the llvm-commits mailing list