[PATCH] D76700: [MLIR] Introduce full/partial tile separation using if/else

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 23:16:23 PDT 2020


bondhugula added a comment.

Thanks for the review!



================
Comment at: mlir/lib/Analysis/AffineStructures.cpp:1242
+    unsigned c, f;
+    for (c = offset, f = offset + num; c < f; ++c) {
+      if (c == pos)
----------------
andydavis1 wrote:
> Can this loop be moved out into a findEqWithNonZero helper function or lambda?
Done - but called it containsConstraintDependentOnRange and reused it for the inequalities loop above as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76700/new/

https://reviews.llvm.org/D76700





More information about the llvm-commits mailing list