[PATCH] D76686: [LV] widenIntOrFpInduction. NFC.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1822
+      SCEVExpander Exp(*PSE.getSE(), DL, "induction");
+      return Exp.expandCodeFor(ID.getStep(), Step->getType(),
+                               LoopVectorPreHeader->getTerminator());
----------------
There's one more ID.getStep() >> Step


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1899
+
   // If an induction variable is only used for counting loop iterations or
   // calculating addresses, it doesn't need to be widened. Create scalar steps
----------------
Not sure where this first "If an induction ... doesn't need to be widened" sentence belongs now, but it doesn't fit here.
The rest does fit before calling buildScalarStep(), which is also/firstly invoked above... better place it there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76686/new/

https://reviews.llvm.org/D76686