[PATCH] D76813: Remove overly verbose debug from GenericDomTreeConstruction
Mehdi AMINI via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 25 17:21:48 PDT 2020
mehdi_amini created this revision.
mehdi_amini added a reviewer: kuhar.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This particular debug shows all the time when I'm processing any MLIR
module:
discovered a new reachable node ^bb0
discovered a new reachable node ^bb0
discovered a new reachable node ^bb0
discovered a new reachable node ^bb0
...
(repeated x1875)
I think that printing all the basic blocks in the function is likely low
value enough that we can get away with removing this.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D76813
Files:
llvm/include/llvm/Support/GenericDomTreeConstruction.h
Index: llvm/include/llvm/Support/GenericDomTreeConstruction.h
===================================================================
--- llvm/include/llvm/Support/GenericDomTreeConstruction.h
+++ llvm/include/llvm/Support/GenericDomTreeConstruction.h
@@ -599,8 +599,6 @@
// Loop over all of the discovered blocks in the function...
for (size_t i = 1, e = NumToNode.size(); i != e; ++i) {
NodePtr W = NumToNode[i];
- LLVM_DEBUG(dbgs() << "\tdiscovered a new reachable node "
- << BlockNamePrinter(W) << "\n");
// Don't replace this with 'count', the insertion side effect is important
if (DT.DomTreeNodes[W]) continue; // Haven't calculated this node yet?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76813.252709.patch
Type: text/x-patch
Size: 714 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200326/ba8caa1a/attachment.bin>
More information about the llvm-commits
mailing list