[PATCH] D76701: [MLIR] Add flat affine constraints method to round trip integer set

[Andy Davis via Phabricator via llvm-commits]

andydavis1 accepted this revision.
andydavis1 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Analysis/AffineStructures.cpp:2719
+        changed = true;
+  } while (changed);
+
----------------
What assures that this doesn't loop forever? 


================
Comment at: mlir/lib/Analysis/AffineStructures.cpp:2729
+/// equalities..
+static bool isColZero(const FlatAffineConstraints &cst, unsigned pos) {
+  assert(pos < cst.getNumCols() && "position out of bounds");
----------------
Thought we had a method that did this already? Or was it just checking for all ones? If so, maybe it could be combined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76701/new/

https://reviews.llvm.org/D76701